swcs/OurUmbraco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing throwing error upon github api not returning 200

Browse Source 
(we already log it and the Accepted status with empty data set is
(hopefully) a throttle issue)
This commit is contained in:
Niels Hartvig
2017-06-23 10:47:50 +02:00
parent ab4ca0015e
commit 1c8fcef754
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
OurUmbraco/Community/Controllers/GitHubContributorController.cs
+5 -3
View File
@@ -87,7 +87,8 @@ namespace OurUmbraco.Community.Controllers
System.IO.File.WriteAllText(JsonPath, rawJson, Encoding.UTF8); System.IO.File.WriteAllText(JsonPath, rawJson, Encoding.UTF8);
model.Contributors = contributors.ToList(); model.Contributors = contributors.ToList();
} catch (Exception ex) }
catch (Exception ex)
{ {
// Log the error so we can debug it later // Log the error so we can debug it later
LogHelper.Error<GitHubContributorController>("Unable to load GitHub contributors from the GitHub API", ex); LogHelper.Error<GitHubContributorController>("Unable to load GitHub contributors from the GitHub API", ex);
@@ -96,7 +97,8 @@ namespace OurUmbraco.Community.Controllers
model.Contributors = GetCachedContributors(); model.Contributors = GetCachedContributors();
} }
} catch (Exception ex) }
catch (Exception ex)
{ {
// Log the error so we can debug it later // Log the error so we can debug it later
LogHelper.Error<GitHubContributorController>("Unable to load GitHub contributors from the GitHub API", ex); LogHelper.Error<GitHubContributorController>("Unable to load GitHub contributors from the GitHub API", ex);
@@ -159,7 +161,7 @@ namespace OurUmbraco.Community.Controllers
} }
return temp; return temp;
} }