Additional null checks

This commit is contained in:
Sebastiaan Janssen
2017-01-29 10:58:12 +01:00
parent 94b5533322
commit bb491d0ac4
2 changed files with 15 additions and 5 deletions
+7 -4
View File
@@ -41,7 +41,7 @@
{
memberRoles.Add(topic.MemberId, topicAuthor.GetRoles());
}
foreach (var comment in topic.Comments)
{
if (topicMembers.Any(x => x.Id == comment.MemberId) == false)
@@ -59,14 +59,17 @@
else
{
commentAuthor = Members.GetById(comment.MemberId);
if (memberRoles.ContainsKey(comment.MemberId) == false)
if (commentAuthor != null && memberRoles.ContainsKey(comment.MemberId) == false)
{
var roles = commentAuthor.GetRoles();
memberRoles.Add(comment.MemberId, roles);
}
}
topicMembers.Add(commentAuthor);
if (commentAuthor != null)
{
topicMembers.Add(commentAuthor);
}
}
}
}
@@ -163,9 +163,16 @@ namespace OurUmbraco.Forum.Extensions
var memberRoles = new List<string>();
if (roles == null)
return memberRoles;
foreach (var role in roles)
{
if (role == "standard" || role.StartsWith("201") || role.ToLowerInvariant().Contains("vendor".ToLowerInvariant()) || role.ToLowerInvariant().Contains("wiki".ToLowerInvariant()) || role.ToLowerInvariant().Contains("potentialspam".ToLowerInvariant()) || role.ToLowerInvariant().Contains("newaccount".ToLowerInvariant()))
if (role == "standard" || role.StartsWith("201") ||
role.ToLowerInvariant().Contains("vendor".ToLowerInvariant()) ||
role.ToLowerInvariant().Contains("wiki".ToLowerInvariant()) ||
role.ToLowerInvariant().Contains("potentialspam".ToLowerInvariant()) ||
role.ToLowerInvariant().Contains("newaccount".ToLowerInvariant()))
continue;
if (role == "CoreContrib")