swcs/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2781 from Mundairson/temp8-U4-11428

Browse Source 
U4-11428 CodeAnnotations classes have inconsistent constructor parameter order
This commit is contained in:
Sebastiaan Janssen
2018-07-19 09:18:17 +02:00
committed by GitHub
parent 6c526b24a0 d7d36c34be
commit 09dd5cf879
3 changed files with 51 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Umbraco.Core/CodeAnnotations/UmbracoExperimentalFeatureAttribute.cs
+18 -12
View File
@@ -3,33 +3,39 @@
namespace Umbraco.Core.CodeAnnotations
{
/// <summary>
/// Marks the program elements that Umbraco is experimenting with and could become public.
/// Marks the program elements that Umbraco is experimenting with and could
/// become public.
/// </summary>
/// <remarks>
/// <para>Indicates that Umbraco is experimenting with code that potentially could become
/// public, but we're not sure, and the code is not stable and can be refactored at any time.</para>
/// <para>The issue tracker should contain more details, discussion, and planning.</para>
/// <para>Indicates that Umbraco is experimenting with code that potentially
/// could become public, but we're not sure, and the code is not stable and
/// can be refactored at any time.</para>
/// <para>The issue tracker should contain more details, discussion, and
/// planning.</para>
/// </remarks>
[AttributeUsage(AttributeTargets.All, AllowMultiple = false, Inherited = false)]
internal sealed class UmbracoExperimentalFeatureAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="UmbracoExperimentalFeatureAttribute"/> class with a description.
/// Initializes a new instance of the <see cref="UmbracoExperimentalFeatureAttribute"/>
/// class with a description.
/// </summary>
/// <param name="description">The text string that describes what is intended.</param>
/// <param name="description">The text string that describes what is
/// intended.</param>
public UmbracoExperimentalFeatureAttribute(string description)
{
}
/// <summary>
/// Initializes a new instance of the <see cref="UmbracoExperimentalFeatureAttribute"/> class with a tracker url and a description.
/// Initializes a new instance of the <see cref="UmbracoExperimentalFeatureAttribute"/>
/// class with a tracker url and a description.
/// </summary>
/// <param name="trackerUrl">The url of a tracker issue containing more details, discussion, and planning.</param>
/// <param name="description">The text string that describes what is intended.</param>
public UmbracoExperimentalFeatureAttribute(string trackerUrl, string description)
/// <param name="description">The text string that describes what is
/// intended.</param>
/// <param name="trackerUrl">The url of a tracker issue containing more
/// details, discussion, and planning.</param>
public UmbracoExperimentalFeatureAttribute(string description, string trackerUrl)
{
}
}
}
src/Umbraco.Core/CodeAnnotations/UmbracoProposedPublicAttribute.cs
+19 -13
View File
@@ -6,31 +6,37 @@ namespace Umbraco.Core.CodeAnnotations
/// Marks the program elements that Umbraco is considering making public.
/// </summary>
/// <remarks>
/// <para>Indicates that Umbraco considers making the (currently internal) program element public
/// at some point in the future, but the decision is not fully made yet and is still pending reviews.</para>
/// <para>Note that it is not a commitment to make the program element public. It may not ever become public.</para>
/// <para>The issue tracker should contain more details, discussion, and planning.</para>
/// <para>Indicates that Umbraco considers making the (currently internal)
/// program element public at some point in the future, but the decision is
/// not fully made yet and is still pending reviews.</para>
/// <para>Note that it is not a commitment to make the program element public.
/// It may not ever become public.</para>
/// <para>The issue tracker should contain more details, discussion, and
/// planning.</para>
/// </remarks>
[AttributeUsage(AttributeTargets.All, AllowMultiple=false, Inherited=false)]
[AttributeUsage(AttributeTargets.All, AllowMultiple = false, Inherited = false)]
internal sealed class UmbracoProposedPublicAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="UmbracoProposedPublicAttribute"/> class with a description.
/// Initializes a new instance of the <see cref="UmbracoProposedPublicAttribute"/>
/// class with a description.
/// </summary>
/// <param name="description">The text string that describes what is intended.</param>
/// <param name="description">The text string that describes what is
/// intended.</param>
public UmbracoProposedPublicAttribute(string description)
{
}
/// <summary>
/// Initializes a new instance of the <see cref="UmbracoProposedPublicAttribute"/> class with a tracker url and a description.
/// Initializes a new instance of the <see cref="UmbracoProposedPublicAttribute"/>
/// class with a tracker url and a description.
/// </summary>
/// <param name="trackerUrl">The url of a tracker issue containing more details, discussion, and planning.</param>
/// <param name="description">The text string that describes what is intended.</param>
public UmbracoProposedPublicAttribute(string trackerUrl, string description)
/// <param name="description">The text string that describes what is
/// intended.</param>
/// <param name="trackerUrl">The url of a tracker issue containing more
/// details, discussion, and planning.</param>
public UmbracoProposedPublicAttribute(string description, string trackerUrl)
{
}
}
}
src/Umbraco.Core/CodeAnnotations/UmbracoWillObsoleteAttribute.cs
+14 -13
View File
@@ -1,7 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
namespace Umbraco.Core.CodeAnnotations
{
@@ -9,29 +6,33 @@ namespace Umbraco.Core.CodeAnnotations
/// Marks the program elements that Umbraco will obsolete.
/// </summary>
/// <remarks>
/// Indicates that Umbraco will obsolete the program element at some point in the future, but we do not want to
/// explicitely mark it [Obsolete] yet to avoid warning messages showing when developers compile Umbraco.
/// Indicates that Umbraco will obsolete the program element at some point
/// in the future, but we do not want to explicitly mark it [Obsolete] yet
/// to avoid warning messages showing when developers compile Umbraco.
/// </remarks>
[AttributeUsage(AttributeTargets.All, AllowMultiple = false, Inherited = false)]
internal sealed class UmbracoWillObsoleteAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="UmbracoWillObsoleteAttribute"/> class with a description.
/// Initializes a new instance of the <see cref="UmbracoWillObsoleteAttribute"/>
/// class with a description.
/// </summary>
/// <param name="description">The text string that describes what is intended.</param>
/// <param name="description">The text string that describes what is
/// intended.</param>
public UmbracoWillObsoleteAttribute(string description)
{
}
/// <summary>
/// Initializes a new instance of the <see cref="UmbracoWillObsoleteAttribute"/> class with a tracker url and a description.
/// Initializes a new instance of the <see cref="UmbracoWillObsoleteAttribute"/>
/// class with a tracker url and a description.
/// </summary>
/// <param name="trackerUrl">The url of a tracker issue containing more details, discussion, and planning.</param>
/// <param name="description">The text string that describes what is intended.</param>
public UmbracoWillObsoleteAttribute(string trackerUrl, string description)
/// <param name="description">The text string that describes what is
/// intended.</param>
/// <param name="trackerUrl">The url of a tracker issue containing more
/// details, discussion, and planning.</param>
public UmbracoWillObsoleteAttribute(string description, string trackerUrl)
{
}
}
}